fix[thin_wallet]: handle address history invalid tx version#1590
Merged
fix[thin_wallet]: handle address history invalid tx version#1590
Conversation
luislhl
force-pushed
the
fix/thin_wallet/address-history-invalid-tx-version
branch
from
58c9fbe to
c966f68
Compare
|
Bencher Report| Branch | fix/thin_wallet/address-history-invalid-tx-version |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.67 m(-2.43%)Baseline: 1.71 m | 1.54 m (92.24%) | 2.06 m (81.31%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1590 +/- ##
==========================================
+ Coverage 85.68% 85.72% +0.03%
==========================================
Files 442 442
Lines 33846 33862 +16
Branches 5293 5297 +4
==========================================
+ Hits 29000 29027 +27
+ Misses 3824 3817 -7
+ Partials 1022 1018 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
raul-oliveira
left a comment
raul-oliveira
left a comment
There was a problem hiding this comment.
Both error responses return 200 with success: False. Consider returning 400 Bad Request for invalid parameters, which is more semantically correct for client errors.
raul-oliveira
approved these changes
Feb 11, 2026
luislhl
force-pushed
the
fix/thin_wallet/address-history-invalid-tx-version
branch
from
656b257 to
8807240
Compare
msbrogli
force-pushed
the
master
branch
2 times, most recently
from
eb416fa to
21d7909
Compare
glevco
approved these changes
Feb 13, 2026
luislhl
force-pushed
the
fix/thin_wallet/address-history-invalid-tx-version
branch
from
8807240 to
e107069
Compare
jansegre
approved these changes
Feb 18, 2026
github-project-automation
bot
moved this from In Review (Done)
to In Review (WIP)
in Hathor Network
luislhl
force-pushed
the
fix/thin_wallet/address-history-invalid-tx-version
branch
from
e107069 to
2a9bd2b
Compare
luislhl
deleted the
fix/thin_wallet/address-history-invalid-tx-version
branch
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
r4mmer
added a commit
that referenced
this pull request
Feb 24, 2026
…' into feat/hathorlib-pydantic-settings * origin/feat/hathorlib-pydantic-settings: fix[thin_wallet]: handle address history invalid tx version (#1590)
r4mmer
added a commit
that referenced
this pull request
Feb 24, 2026
…print-move-1 * origin/master: feat: pydantic settings (#1600) fix[thin_wallet]: handle address history invalid tx version (#1590) refactor(nano): Make NCBlockExecutor a pure executor with no side effects fix[nginx]: Make sure we trust the GCP IPs to get the real client IP (#1595) refactor: Upgrade to Pydantic v2 chore(github): Split GitHub main action into lint, test-cli, test-lib, test-other fix[nginx]: Use a larger buffer size for /v1a/status (#1594) chore: adjust testnet config for v0.69.0 release chore[storage]: Limit the total size of RocksDB WAL files (#1518) chore: adjust testnet config for v0.69.0 release chore: configure feature activations for v0.69.0 release refactor: wallet on_new_tx (#1561) refactor(nano): Remove dead reorg cleanup code from block executor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There is an exception not treated when an user inputs invalid tx version in the
/address_historyendpoint: https://hathor.app.opsgenie.com/alert/detail/6b7fd5dd-05d4-4347-b334-54f662c64fda-1769746499423/detailsAcceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged